Test against Rails 5 #229
Merged
Test against Rails 5 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # supported in Rails 5+. Since we support back to 4, we need some sort of shim | ||
| # to avoid super noisy deprecations when running tests. | ||
| module HTTPMethodShim | ||
| def get(path, params=nil, headers=nil) |
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
|
👍 |
|
Thanks @derekprior / @tute |
Heavily inspired by derekprior's work on testing Clearance against Rails 5. This will pave the way to releasing HighVoltage 3.0 which removes caching support but provides Rails 5 support.
teoljungberg
added a commit
to thoughtbot/administrate
that referenced
this pull request
Aug 1, 2016
This provides backward compatibility with Rails 5. Inspiration taken from: - thoughtbot/high_voltage#229 - thoughtbot/clearance#639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily inspired by @derekprior's work on testing Clearance against Rails 5.
This will pave the way to releasing HighVoltage 3.0 which removes
caching support but provides Rails 5 support.